[8.x] Add command to clean batches table #35694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmason30
changed the title
driesvints
reviewed
Dec 22, 2020
driesvints
reviewed
Dec 22, 2020
driesvints
reviewed
Dec 22, 2020
|
I'm not sure if "flush-batch" is the right word? That makes me think all of the table's records will be deleted when really it's just pruning existing ones. |
GrahamCampbell
requested changes
Dec 22, 2020
|
@taylorotwell I agree, As I mentioned in the OP |
|
I would likely call it something like |
|
Pushed change to |
| /** | ||
| * Prune all of the entries older than the given date. | ||
| * | ||
| * @param DateTimeInterface $before |
| /** | ||
| * Prune all of the entries older than the given date. | ||
| * | ||
| * @param DateTimeInterface $before |
| $totalDeleted = 0; | ||
|
|
||
| do { | ||
| $deleted = $query->take(1000)->delete(); |
There was a problem hiding this comment.
Why don't you just use the query builder's each function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a
queue:prune-batchescommand for cleaning thejob_batchestable added in 8.x.Heavily inspired by the
telescope:prunecommand this change is almost an exact copy of that.https://github.com/laravel/telescope/blob/master/src/Console/PruneCommand.php
It has an
--hoursoptional argument that defaults to24and it uses thefinished_atcolumn to do the date comparison.Similarly to telescope it can easily be put into the scheduler:
None of the queue commands currently have tests so I haven't added any for this one.
If you want me to add tests please do let me know.